From 1c05ebf522f0bb5776ba51a46d94aa101220fea1 Mon Sep 17 00:00:00 2001
From: AlexeyAB <alexeyab84@gmail.com>
Date: Thu, 07 Jun 2018 00:39:30 +0000
Subject: [PATCH] Minor fix

---
 src/detector.c |  134 +++++++++++++++++++++++++-------------------
 1 files changed, 75 insertions(+), 59 deletions(-)

diff --git a/src/detector.c b/src/detector.c
index 3b486fb..0c0b14d 100644
--- a/src/detector.c
+++ b/src/detector.c
@@ -1,8 +1,3 @@
-#ifdef _DEBUG
-#include <stdlib.h> 
-#include <crtdbg.h>  
-#endif
-
 #include "network.h"
 #include "region_layer.h"
 #include "cost_layer.h"
@@ -92,7 +87,8 @@
     load_args args = {0};
     args.w = net.w;
     args.h = net.h;
-    args.paths = paths;
+	args.c = net.c;
+	args.paths = paths;
     args.n = imgs;
     args.m = plist->size;
     args.classes = classes;
@@ -110,7 +106,7 @@
     args.hue = net.hue;
 
 #ifdef OPENCV
-	args.threads = 3;
+	args.threads = 3 * ngpus;
 	IplImage* img = NULL;
 	float max_img_loss = 5;
 	int number_of_lines = 100;
@@ -129,9 +125,15 @@
 			//int dim = (rand() % 12 + (init_w/32 - 5)) * 32;	// +-160
             //int dim = (rand() % 4 + 16) * 32;
 			//if (get_current_batch(net)+100 > net.max_batches) dim = 544;
-			int random_val = rand() % 12;
-			int dim_w = (random_val + (init_w / 32 - 5)) * 32;	// +-160
-			int dim_h = (random_val + (init_h / 32 - 5)) * 32;	// +-160
+			
+			//int random_val = rand() % 12;
+			//int dim_w = (random_val + (init_w / 32 - 5)) * 32;	// +-160
+			//int dim_h = (random_val + (init_h / 32 - 5)) * 32;	// +-160
+
+			float random_val = rand_scale(1.4);	// *x or /x
+			int dim_w = roundl(random_val*init_w / 32) * 32;
+			int dim_h = roundl(random_val*init_h / 32) * 32;
+
 			if (dim_w < 32) dim_w = 32;
 			if (dim_h < 32) dim_h = 32;
 
@@ -188,7 +190,7 @@
         avg_loss = avg_loss*.9 + loss*.1;
 
         i = get_current_batch(net);
-        printf("\n %d: %f, %f avg, %f rate, %lf seconds, %d images\n", get_current_batch(net), loss, avg_loss, get_current_rate(net), (what_time_is_it_now()-time), i*imgs);
+        printf("\n %d: %f, %f avg loss, %f rate, %lf seconds, %d images\n", get_current_batch(net), loss, avg_loss, get_current_rate(net), (what_time_is_it_now()-time), i*imgs);
 
 #ifdef OPENCV
 		if(!dont_show)
@@ -215,8 +217,25 @@
     sprintf(buff, "%s/%s_final.weights", backup_directory, base);
     save_weights(net, buff);
 
-	//cvReleaseImage(&img);
-	//cvDestroyAllWindows();
+#ifdef OPENCV
+	cvReleaseImage(&img);
+	cvDestroyAllWindows();
+#endif
+
+	// free memory
+	pthread_join(load_thread, 0);
+	free_data(buffer);
+
+	free(base);
+	free(paths);
+	free_list_contents(plist);
+	free_list(plist);
+
+	free_list_contents_kvp(options);
+	free_list(options);
+
+	free(nets);
+	free_network(net);
 }
 
 
@@ -370,6 +389,7 @@
 	load_args args = { 0 };
 	args.w = net.w;
 	args.h = net.h;
+	args.c = net.c;
 	args.type = IMAGE_DATA;
 	//args.type = LETTERBOX_DATA;
 
@@ -464,7 +484,7 @@
 
 	for (i = 0; i < m; ++i) {
 		char *path = paths[i];
-		image orig = load_image_color(path, 0, 0);
+		image orig = load_image(path, 0, 0, net.c);
 		image sized = resize_image(orig, net.w, net.h);
 		char *id = basecfg(path);
 		network_predict(net, sized.data);
@@ -474,14 +494,7 @@
 		if (nms) do_nms_obj(dets, nboxes, 1, nms);
 
 		char labelpath[4096];
-		find_replace(path, "images", "labels", labelpath);
-		find_replace(labelpath, "JPEGImages", "labels", labelpath);
-		find_replace(labelpath, ".jpg", ".txt", labelpath);
-		find_replace(labelpath, ".png", ".txt", labelpath);
-		find_replace(labelpath, ".bmp", ".txt", labelpath);
-		find_replace(labelpath, ".JPG", ".txt", labelpath);
-		find_replace(labelpath, ".JPEG", ".txt", labelpath);
-		find_replace(labelpath, ".ppm", ".txt", labelpath);
+		replace_image_to_label(path, labelpath);
 
 		int num_labels = 0;
 		box_label *truth = read_boxes(labelpath, &num_labels);
@@ -543,6 +556,7 @@
 	char *mapf = option_find_str(options, "map", 0);
 	int *map = 0;
 	if (mapf) map = read_map(mapf);
+	FILE* reinforcement_fd = NULL;
 
 	network net = parse_network_cfg_custom(cfgfile, 1);	// set batch=1
 	if (weightfile) {
@@ -583,6 +597,7 @@
 	load_args args = { 0 };
 	args.w = net.w;
 	args.h = net.h;
+	args.c = net.c;
 	args.type = IMAGE_DATA;
 	//args.type = LETTERBOX_DATA;
 
@@ -632,14 +647,7 @@
 			if (nms) do_nms_sort(dets, nboxes, l.classes, nms);
 
 			char labelpath[4096];
-			find_replace(path, "images", "labels", labelpath);
-			find_replace(labelpath, "JPEGImages", "labels", labelpath);
-			find_replace(labelpath, ".jpg", ".txt", labelpath);
-			find_replace(labelpath, ".png", ".txt", labelpath);
-			find_replace(labelpath, ".bmp", ".txt", labelpath);
-			find_replace(labelpath, ".JPG", ".txt", labelpath);
-			find_replace(labelpath, ".JPEG", ".txt", labelpath);
-			find_replace(labelpath, ".ppm", ".txt", labelpath);
+			replace_image_to_label(path, labelpath);
 			int num_labels = 0;
 			box_label *truth = read_boxes(labelpath, &num_labels);
 			int i, j;
@@ -655,11 +663,8 @@
 				char *path_dif = paths_dif[image_index];
 
 				char labelpath_dif[4096];
-				find_replace(path_dif, "images", "labels", labelpath_dif);
-				find_replace(labelpath_dif, "JPEGImages", "labels", labelpath_dif);
-				find_replace(labelpath_dif, ".jpg", ".txt", labelpath_dif);
-				find_replace(labelpath_dif, ".JPEG", ".txt", labelpath_dif);
-				find_replace(labelpath_dif, ".png", ".txt", labelpath_dif);				
+				replace_image_to_label(path_dif, labelpath_dif);
+			
 				truth_dif = read_boxes(labelpath_dif, &num_labels_dif);
 			}
 
@@ -731,9 +736,18 @@
 					}
 				}
 			}
-			
+				
 			unique_truth_count += num_labels;
 
+			//static int previous_errors = 0;
+			//int total_errors = fp_for_thresh + (unique_truth_count - tp_for_thresh);
+			//int errors_in_this_image = total_errors - previous_errors;
+			//previous_errors = total_errors;
+			//if(reinforcement_fd == NULL) reinforcement_fd = fopen("reinforcement.txt", "wb");
+			//char buff[1000];
+			//sprintf(buff, "%s\n", path);
+			//if(errors_in_this_image > 0) fwrite(buff, sizeof(char), strlen(buff), reinforcement_fd);
+
 			free_detections(dets, nboxes);
 			free(id);
 			free_image(val[t]);
@@ -854,6 +868,7 @@
 	free(truth_classes_count);
 
 	fprintf(stderr, "Total Detection Time: %f Seconds\n", (double)(time(0) - start));
+	if (reinforcement_fd != NULL) fclose(reinforcement_fd);
 }
 
 #ifdef OPENCV
@@ -896,14 +911,8 @@
 	for (i = 0; i < number_of_images; ++i) {
 		char *path = paths[i];
 		char labelpath[4096];
-		find_replace(path, "images", "labels", labelpath);
-		find_replace(labelpath, "JPEGImages", "labels", labelpath);
-		find_replace(labelpath, ".jpg", ".txt", labelpath);
-		find_replace(labelpath, ".png", ".txt", labelpath);
-		find_replace(labelpath, ".bmp", ".txt", labelpath);
-		find_replace(labelpath, ".JPG", ".txt", labelpath);
-		find_replace(labelpath, ".JPEG", ".txt", labelpath);
-		find_replace(labelpath, ".ppm", ".txt", labelpath);
+		replace_image_to_label(path, labelpath);
+
 		int num_labels = 0;
 		box_label *truth = read_boxes(labelpath, &num_labels);
 		//printf(" new path: %s \n", labelpath);
@@ -1056,11 +1065,12 @@
 #endif // OPENCV
 
 void test_detector(char *datacfg, char *cfgfile, char *weightfile, char *filename, float thresh,
-				   float hier_thresh, int dont_show, int ext_output)
+				   float hier_thresh, int dont_show, int ext_output, int save_labels)
 {
     list *options = read_data_cfg(datacfg);
     char *name_list = option_find_str(options, "names", "data/names.list");
-    char **names = get_labels(name_list);
+	int names_size = 0;
+	char **names = get_labels_custom(name_list, &names_size); //get_labels(name_list);
 
     image **alphabet = load_alphabet();
     network net = parse_network_cfg_custom(cfgfile, 1); // set batch=1
@@ -1069,6 +1079,11 @@
     }
     //set_batch_network(&net, 1);
 	fuse_conv_batchnorm(net);
+	if (net.layers[net.n - 1].classes != names_size) {
+		printf(" Error: in the file %s number of names %d that isn't equal to classes=%d in the file %s \n", 
+			name_list, names_size, net.layers[net.n - 1].classes, datacfg);
+		if(net.layers[net.n - 1].classes > names_size) getchar();
+	}
     srand(2222222);
     double time;
     char buff[256];
@@ -1087,10 +1102,10 @@
             if(!input) return;
             strtok(input, "\n");
         }
-        image im = load_image_color(input,0,0);
+        image im = load_image(input,0,0,net.c);
 		int letterbox = 0;
-        //image sized = resize_image(im, net.w, net.h);
-		image sized = letterbox_image(im, net.w, net.h); letterbox = 1;
+        image sized = resize_image(im, net.w, net.h);
+		//image sized = letterbox_image(im, net.w, net.h); letterbox = 1;
         layer l = net.layers[net.n-1];
 
         //box *boxes = calloc(l.w*l.h*l.n, sizeof(box));
@@ -1113,16 +1128,12 @@
 		if (!dont_show) {
 			show_image(im, "predictions");
 		}
-/*
+
 		// pseudo labeling concept - fast.ai
+		if(save_labels)
 		{
 			char labelpath[4096];
-			find_replace(input, ".jpg", ".txt", labelpath);
-			find_replace(labelpath, ".png", ".txt", labelpath);
-			find_replace(labelpath, ".bmp", ".txt", labelpath);
-			find_replace(labelpath, ".JPG", ".txt", labelpath);
-			find_replace(labelpath, ".JPEG", ".txt", labelpath);
-			find_replace(labelpath, ".ppm", ".txt", labelpath);
+			replace_image_to_label(input, labelpath);
 
 			FILE* fw = fopen(labelpath, "wb");
 			int i;
@@ -1143,7 +1154,7 @@
 			}
 			fclose(fw);
 		}
-*/
+
 		free_detections(dets, nboxes);
         free_image(im);
         free_image(sized);
@@ -1160,6 +1171,7 @@
 
 	// free memory
 	free_ptrs(names, net.layers[net.n - 1].classes);
+	free_list_contents_kvp(options);
 	free_list(options);
 
 	int i;
@@ -1193,6 +1205,7 @@
 	// extended output in test mode (output of rect bound coords)
 	// and for recall mode (extended output table-like format with results for best_class fit)
 	int ext_output = find_arg(argc, argv, "-ext_output");
+	int save_labels = find_arg(argc, argv, "-save_labels");
     if(argc < 4){
         fprintf(stderr, "usage: %s %s [train/test/valid] [cfg] [weights (optional)]\n", argv[0], argv[1]);
         return;
@@ -1229,7 +1242,7 @@
 		if(strlen(weights) > 0)
 			if (weights[strlen(weights) - 1] == 0x0d) weights[strlen(weights) - 1] = 0;
     char *filename = (argc > 6) ? argv[6]: 0;
-    if(0==strcmp(argv[2], "test")) test_detector(datacfg, cfg, weights, filename, thresh, hier_thresh, dont_show, ext_output);
+    if(0==strcmp(argv[2], "test")) test_detector(datacfg, cfg, weights, filename, thresh, hier_thresh, dont_show, ext_output, save_labels);
     else if(0==strcmp(argv[2], "train")) train_detector(datacfg, cfg, weights, gpus, ngpus, clear, dont_show);
     else if(0==strcmp(argv[2], "valid")) validate_detector(datacfg, cfg, weights, outfile);
     else if(0==strcmp(argv[2], "recall")) validate_detector_recall(datacfg, cfg, weights);
@@ -1244,7 +1257,10 @@
 			if(strlen(filename) > 0)
 				if (filename[strlen(filename) - 1] == 0x0d) filename[strlen(filename) - 1] = 0;
         demo(cfg, weights, thresh, hier_thresh, cam_index, filename, names, classes, frame_skip, prefix, out_filename,
-			http_stream_port, dont_show);
+			http_stream_port, dont_show, ext_output);
+
+		free_list_contents_kvp(options);
+		free_list(options);
     }
 	else printf(" There isn't such command: %s", argv[2]);
 }

--
Gitblit v1.10.0